Skip to content

feat: add django 6.0 and python 3.14 support#959

Merged
vgrozdanic merged 2 commits intojazzband:masterfrom
angryfoxx:master
Feb 9, 2026
Merged

feat: add django 6.0 and python 3.14 support#959
vgrozdanic merged 2 commits intojazzband:masterfrom
angryfoxx:master

Conversation

@angryfoxx
Copy link
Copy Markdown
Contributor

No description provided.

@Gauravwagh
Copy link
Copy Markdown

Gauravwagh commented Feb 2, 2026

PR Review: Django 6.0 and Python 3.14 Support

Thanks for this PR! The changes look solid overall. Here's my review:

✅ What's Good

  • Deprecation fix — Replacing pkg_resources.get_distribution with importlib.metadata.version is the right call since pkg_resources is deprecated
  • Sensible exclusions — Excluding Python 3.14 from Django 4.2/5.0/5.1 makes sense
  • Consistent updates — All relevant files (CI, tox, setup.py) are updated together
  • DRF 3.16 inclusion — Good for forward compatibility

⚠️ Issues to Address

1. Missing DRF 3.14 exclusions for Django 5.2/6.0

The existing exclusions suggest DRF 3.14 has compatibility issues with Django 5.x. Should add:

- drf-version: '3.14'
  django-version: '5.2'
- drf-version: '3.14'
  django-version: '6.0'

2. Inconsistency between tox.ini and GitHub Actions

GitHub Actions tests Django 6.0 with Python 3.12/3.13/3.14, but tox.ini only has:

py314-dj{52,60}-drf{315,316}-pyjwt{171,2}-tests

Consider adding py{312,313,314}-dj60-... to tox.ini for consistency.

3. Python 3.10 added to Django 5.2 in tox.ini

The original config had py{311,312,313}-dj52-..., but now it's py{310,311,312,313}-dj{51,52}-.... Can you verify Django 5.2 officially supports Python 3.10?


📝 Missing Items

  • CHANGELOG.md — Should document the new Django 6.0 / Python 3.14 support
  • docs/getting_started.rst — Update the supported versions list

@jazzband Could you please add support for Django 6.0 soon?

Copy link
Copy Markdown
Contributor

@vgrozdanic vgrozdanic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks!

@vgrozdanic vgrozdanic merged commit 6a9e048 into jazzband:master Feb 9, 2026
56 checks passed
Andrew-Chen-Wang added a commit that referenced this pull request Feb 10, 2026
Was not added in this PR: #959
vgrozdanic pushed a commit that referenced this pull request Feb 11, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants